Skip to content

Conversation

@LiGaCu
Copy link
Contributor

@LiGaCu LiGaCu commented May 12, 2025

Problem

In order to coordinate the new aws/language-servers#1348 change, GenerateCompletions requests would start expecting the fileUri field to be set.

Solution

Add fileUri to FileContext


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@LiGaCu LiGaCu force-pushed the file_uri branch 2 times, most recently from 5dde7e9 to c0ffdb9 Compare May 16, 2025 01:23
@LiGaCu LiGaCu marked this pull request as ready for review May 19, 2025 16:37
@LiGaCu LiGaCu requested review from a team as code owners May 19, 2025 16:37
@leigaol
Copy link
Contributor

leigaol commented May 19, 2025

Is it good to merge? Does server side throw 4xx if we merge and ship this?

@leigaol leigaol merged commit e564ef6 into aws:master May 19, 2025
29 of 31 checks passed
@opieter-aws
Copy link
Contributor

We are migrating Inline suggestions to Flare LSP next week (see this branch: https://github.com/aws/aws-toolkit-vscode/tree/feature/flare-mega)

In that new implementation, the edited files here are fully deleted, so these changes won't be part of that release

@LiGaCu
Copy link
Contributor Author

LiGaCu commented May 19, 2025

We are migrating Inline suggestions to Flare LSP next week (see this branch: https://github.com/aws/aws-toolkit-vscode/tree/feature/flare-mega)

In that new implementation, the edited files here are fully deleted, so these changes won't be part of that release

Sounds good. Will incorporate the change in Flare LSP as well. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants